Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1070203002: Issue 23133. Fix for restoring 'package:' uris on Windows. (Closed)

Created:
5 years, 8 months ago by scheglov
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M pkg/analyzer/lib/source/package_map_resolver.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/analyzer/test/source/package_map_resolver_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
scheglov
5 years, 8 months ago (2015-04-09 18:05:39 UTC) #1
Paul Berry
Fix lgtm. Can you please add a unit test to make sure this case doesn't ...
5 years, 8 months ago (2015-04-09 18:16:39 UTC) #2
scheglov
On 2015/04/09 18:16:39, Paul Berry wrote: > Fix lgtm. Can you please add a unit ...
5 years, 8 months ago (2015-04-09 18:21:52 UTC) #3
scheglov
Committed patchset #1 (id:1) manually as 45023 (presubmit successful).
5 years, 8 months ago (2015-04-09 18:23:48 UTC) #4
Siggi Cherem (dart-lang)
A couple tests in the bots started failing around the time this CL was submitted. ...
5 years, 8 months ago (2015-04-09 23:55:45 UTC) #6
scheglov
5 years, 8 months ago (2015-04-10 04:19:23 UTC) #7
Message was sent while issue was closed.
On 2015/04/09 23:55:45, Siggi Cherem (dart-lang) wrote:
> A couple tests in the bots started failing around the time this CL was
> submitted. See:
> 
>
http://chromegw.corp.google.com/i/client.dart/builders/pub-win-debug-be/build...
> 
> and:
>
http://chromegw.corp.google.com/i/client.dart/builders/pub-win-be/builds/9611...
> 
> The failures sound like it is related, but I'm not sure if this is the change
> that caused that or some other change.

Yes, you are right, there is a failing test and it related to this CL.
I will fix it tomorrow.

Powered by Google App Engine
This is Rietveld 408576698