Issue 1051133002: *Properly* fix that package-root bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1051133002: Properly fix that package-root bug. (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

*Properly* fix that package-root bug. It turns out internally we expect the package root to be a path, so we should only convert it at the boundary to dart2js. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/c67bd5b647020a4d5381314ad7a19e9eb4ff9d74

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -3 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/src/runner/browser/compiler_pool.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/src/util/io.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

nweiz

5 years, 8 months ago (2015-04-02 01:31:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c67bd5b647020a4d5381314ad7a19e9eb4ff9d74 (presubmit successful).