lib/src/runner/browser/compiler_pool.dart - Issue 1051133002: *Properly* fix that package-root bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/runner/browser/compiler_pool.dart

Issue 1051133002: *Properly* fix that package-root bug. (Closed) Base URL: git@github.com:dart-lang/test@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/runner/browser/compiler_pool.dart

diff --git a/lib/src/runner/browser/compiler_pool.dart b/lib/src/runner/browser/compiler_pool.dart

index 7ccecf81ec67147a72ca44b6e467d21e5dfd16e8..e5ba0565fe9e48b7124973a2fe34974ebbef4b6c 100644

--- a/lib/src/runner/browser/compiler_pool.dart

+++ b/lib/src/runner/browser/compiler_pool.dart

@@ -73,7 +73,7 @@ void main(_) {

var args = ["--checked", wrapperPath, "--out=$jsPath"];

if (packageRoot != null) {

- args.add("--package-root=${p.absolute(packageRoot)}");

+ args.add("--package-root=${p.toUri(p.absolute(packageRoot))}");

}

if (_color) args.add("--enable-diagnostic-colors");

« no previous file with comments | « CHANGELOG.md ('k') | lib/src/util/io.dart » ('j') | no next file with comments »