Issue 1049933002: Implement bigint shift intrinsics on x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1049933002: Implement bigint shift intrinsics on x64. (Closed)

Created:
5 years, 8 months ago by regis

Modified:
5 years, 8 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Implement bigint shift intrinsics on x64. Add assembler support and tests for shld and shrd instructions on x64. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=44834

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+193 lines, -11 lines)			Patch
M	runtime/lib/bigint.dart	View		8 chunks	+11 lines, -11 lines	0 comments	Download
M	runtime/vm/assembler_x64.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View		1 chunk	+22 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64_test.cc	View		1 chunk	+36 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm64.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1	1 chunk	+78 lines, -0 lines	0 comments	Download
M	runtime/vm/method_recognizer.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

regis

5 years, 8 months ago (2015-04-01 17:36:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r44834 (presubmit successful).