Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Issue 1049113004: Improve the detection of which platforms support Isolate.kill. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve the detection of which platforms support Isolate.kill. This was returning false negatives for Dart 1.10. R=kevmoo@google.com Committed: https://github.com/dart-lang/unittest/commit/d03a46da4877c5d88be36d2c8f1dd327fc1f0c5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M lib/src/util/io.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 8 months ago (2015-03-31 01:19:14 UTC) #1
kevmoo
lgtm
5 years, 8 months ago (2015-03-31 03:02:59 UTC) #2
nweiz
5 years, 8 months ago (2015-03-31 19:49:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d03a46da4877c5d88be36d2c8f1dd327fc1f0c5a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698