Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: lib/src/util/io.dart

Issue 1049113004: Improve the detection of which platforms support Isolate.kill. (Closed) Base URL: git@github.com:dart-lang/unittest@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/util/io.dart
diff --git a/lib/src/util/io.dart b/lib/src/util/io.dart
index c14e32f56bc86eda13003b87f9b34482c18a9654..65bb9cde6e0f822d68a63144a64079f0eb2a8405 100644
--- a/lib/src/util/io.dart
+++ b/lib/src/util/io.dart
@@ -39,7 +39,7 @@ bool get _supportsIsolateKill {
// Isolate.kill(), but it's very unlikely anyone will be using them.
// TODO(nweiz): remove this when we no longer support older Dart versions.
var path = p.join(p.dirname(p.dirname(Platform.executable)), 'version');
- return new File(path).readAsStringSync().startsWith('1.9');
+ return !new File(path).readAsStringSync().startsWith('1.8');
}
// TODO(nweiz): Make this check [stdioType] once that works within "pub run".
« no previous file with comments | « no previous file | pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698