Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1047673002: Add SemanticDeclVisitor. (Closed)

Created:
5 years, 8 months ago by Johnni Winther
Modified:
5 years, 8 months ago
Reviewers:
karlklose, floitsch
CC:
reviews_dartlang.org, Anders Johnsen
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Correct long lines #

Total comments: 1

Patch Set 3 : Add bulk mixins. #

Patch Set 4 : Updated cf. comments. #

Patch Set 5 : Rebased #

Patch Set 6 : More renaming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4755 lines, -1123 lines) Patch
M pkg/analyzer2dart/lib/src/modely.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 2 3 4 3 chunks +7 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 1 2 3 4 5 3 chunks +622 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 1 2 3 4 5 5 chunks +1033 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 2 3 4 1 chunk +306 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 1 2 3 4 1 chunk +203 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 2 3 4 5 8 chunks +2581 lines, -1084 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
https://codereview.chromium.org/1047673002/diff/20001/pkg/analyzer2dart/lib/src/modely.dart File pkg/analyzer2dart/lib/src/modely.dart (right): https://codereview.chromium.org/1047673002/diff/20001/pkg/analyzer2dart/lib/src/modely.dart#newcode835 pkg/analyzer2dart/lib/src/modely.dart:835: bool get isRedirectingGenerative => false; Missing from https://codereview.chromium.org/1043723002/
5 years, 8 months ago (2015-03-30 11:10:10 UTC) #2
Johnni Winther
ping
5 years, 8 months ago (2015-04-10 08:49:44 UTC) #3
karlklose
LGTM. Could you change 'Decl' -> 'Declaration' in most places?
5 years, 8 months ago (2015-04-10 09:18:45 UTC) #4
Johnni Winther
5 years, 8 months ago (2015-04-10 15:07:16 UTC) #5
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as 45068 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698