Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1043513002: Enable strict flags for all service tests (Closed)

Created:
5 years, 8 months ago by Cutch
Modified:
5 years, 8 months ago
Reviewers:
turnidge, rmacnak
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Enable strict flags for all service tests BUG= R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=44765

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -18 lines) Patch
M runtime/bin/main.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/test/allocations_test.dart View 1 chunk +1 line, -0 lines 1 comment Download
M runtime/observatory/test/async_generator_breakpoint_test.dart View 1 chunk +1 line, -1 line 2 comments Download
M runtime/observatory/test/bad_web_socket_address_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/caching_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/call_site_data_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/classes_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/code_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/command_test.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/observatory/test/contexts_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/coverage_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/debugging_test.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/observatory/test/dominator_tree_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/observatory/test/echo_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/eval_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/functions_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/gc_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/graph_test.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M runtime/observatory/test/inbound_references_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/isolate_lifecycle_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/malformed_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/metrics_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/mirror_references_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/native_metrics_test.dart View 1 chunk +5 lines, -0 lines 2 comments Download
M runtime/observatory/test/source_location_test.dart View 7 chunks +9 lines, -8 lines 0 comments Download
M runtime/observatory/test/string_escaping_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/test_helper.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/type_arguments_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/test/vm_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/observatory/test/weak_properties_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Cutch
5 years, 8 months ago (2015-03-27 17:14:56 UTC) #3
turnidge
https://codereview.chromium.org/1043513002/diff/1/runtime/observatory/test/async_generator_breakpoint_test.dart File runtime/observatory/test/async_generator_breakpoint_test.dart (right): https://codereview.chromium.org/1043513002/diff/1/runtime/observatory/test/async_generator_breakpoint_test.dart#newcode5 runtime/observatory/test/async_generator_breakpoint_test.dart:5: // VMOptions=--verbose-debug Combine. https://codereview.chromium.org/1043513002/diff/1/runtime/observatory/test/native_metrics_test.dart File runtime/observatory/test/native_metrics_test.dart (right): https://codereview.chromium.org/1043513002/diff/1/runtime/observatory/test/native_metrics_test.dart#newcode1 runtime/observatory/test/native_metrics_test.dart:1: ...
5 years, 8 months ago (2015-03-27 17:25:18 UTC) #4
turnidge
lgtm
5 years, 8 months ago (2015-03-27 17:25:24 UTC) #5
Cutch
https://codereview.chromium.org/1043513002/diff/1/runtime/observatory/test/async_generator_breakpoint_test.dart File runtime/observatory/test/async_generator_breakpoint_test.dart (right): https://codereview.chromium.org/1043513002/diff/1/runtime/observatory/test/async_generator_breakpoint_test.dart#newcode5 runtime/observatory/test/async_generator_breakpoint_test.dart:5: // VMOptions=--verbose-debug On 2015/03/27 17:25:18, turnidge wrote: > Combine. ...
5 years, 8 months ago (2015-03-27 23:32:00 UTC) #6
Cutch
Committed patchset #1 (id:1) manually as 44765 (presubmit successful).
5 years, 8 months ago (2015-03-27 23:32:47 UTC) #7
rmacnak
5 years, 8 months ago (2015-03-27 23:58:51 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/1043513002/diff/1/runtime/observatory/test/al...
File runtime/observatory/test/allocations_test.dart (right):

https://codereview.chromium.org/1043513002/diff/1/runtime/observatory/test/al...
runtime/observatory/test/allocations_test.dart:4: // VMOptions=--compile-all
--error_on_bad_type --error_on_bad_override --checked
I wouldn't include --checked.  The bots already run the tests in both checked
mode and production mode, so specifying --checked here just means we aren't
testing production mode anymore.

Powered by Google App Engine
This is Rietveld 408576698