Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1530)

Unified Diff: runtime/observatory/test/graph_test.dart

Issue 1043513002: Enable strict flags for all service tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/test/graph_test.dart
diff --git a/runtime/observatory/test/graph_test.dart b/runtime/observatory/test/graph_test.dart
index a49608879fb69e04b9e9a2b8fddd9c23f1a4699d..7bc5b0b40bb80ca7da67a1dbee6d77a8f0756dcb 100644
--- a/runtime/observatory/test/graph_test.dart
+++ b/runtime/observatory/test/graph_test.dart
@@ -1,6 +1,7 @@
// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+// VMOptions=--compile-all --error_on_bad_type --error_on_bad_override --checked
import 'dart:async';
import 'package:observatory/object_graph.dart';
@@ -25,7 +26,7 @@ void script() {
r.left = a;
r.right = b;
a.left = b;
-
+
lst = new List(2);
lst[0] = lst; // Self-loop.
// Larger than any other fixed-size list in a fresh heap.
@@ -52,14 +53,14 @@ var tests = [
(ObjectVertex obj) => obj.succ.length == 1).length, equals(1));
expect(foos.where(
(ObjectVertex obj) => obj.succ.length == 2).length, equals(1));
-
+
ObjectVertex bVertex = foos.where(
(ObjectVertex obj) => obj.succ.length == 0).first;
ObjectVertex aVertex = foos.where(
(ObjectVertex obj) => obj.succ.length == 1).first;
ObjectVertex rVertex = foos.where(
(ObjectVertex obj) => obj.succ.length == 2).first;
-
+
// TODO(koda): Check actual byte sizes.
expect(aVertex.retainedSize, equals(aVertex.shallowSize));
@@ -67,7 +68,7 @@ var tests = [
expect(rVertex.retainedSize, equals(aVertex.shallowSize +
bVertex.shallowSize +
rVertex.shallowSize));
-
+
const int fixedSizeListCid = 62;
List<ObjectVertex> lists = new List.from(graph.vertices.where(
(ObjectVertex obj) => obj.classId == fixedSizeListCid));

Powered by Google App Engine
This is Rietveld 408576698