Issue 1039223002: Revert "Clean up naming scheme for reflection names."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1039223002: Revert "Clean up naming scheme for reflection names." (Closed)

Created:
5 years, 9 months ago by herhut

Modified:
5 years, 9 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Revert "Clean up naming scheme for reflection names." This reverts commit r44732. BUG= TBR=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=44733

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -51 lines)			Patch
M	pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart	View	3 chunks	+15 lines, -7 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/js_mirrors.dart	View	4 chunks	+5 lines, -8 lines	0 comments	Download
D	tests/lib/mirrors/optional_parameters_test.dart	View	1 chunk	+0 lines, -30 lines	0 comments	Download

Total messages: 3 (0 generated)

herhut

Committed patchset #1 (id:1) manually as 44733 (presubmit successful).

5 years, 9 months ago (2015-03-27 13:38:59 UTC) #2

ahe

5 years, 9 months ago (2015-03-27 13:44:08 UTC) #3

Message was sent while issue was closed.

lgtm

Could you add some information to this CL about why you had to revert