Revert "Clean up naming scheme for reflection names."

pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.js_emitter;
 
 // TODO(ahe): Share these with js_helper.dart.
 const FUNCTION_INDEX = 0;
 const NAME_INDEX = 1;
 const CALL_NAME_INDEX = 2;
@@ skipping 665 matching lines @@
         f.\$callName = null;
         // Update the interceptedNames map (which only exists if `invokeOn` was
         // enabled).
         if (#enabledInvokeOn)
           if (isIntercepted) #interceptedNames[getterStubName] = 1;
       }
 
       if (#usesMangledNames) {
         var isReflectable = array.length > unmangledNameIndex;
         if (isReflectable) {
-          funcs[0].$reflectableField = 1;
-          funcs[0].$reflectionInfoField = array;
-          for (var i = 1; i < funcs.length; i++) {
-            funcs[i].$reflectableField = 2;
+          for (var i = 0; i < funcs.length; i++) {
+            funcs[i].$reflectableField = 1;
             funcs[i].$reflectionInfoField = array;
           }
           var mangledNames = isStatic ? #mangledGlobalNames : #mangledNames;
           var unmangledName = ${readString("array", "unmangledNameIndex")};
           // The function is either a getter, a setter, or a method.
           // If it is a method, it might also have a tear-off closure.
           // The unmangledName is the same as the getter-name.
           var reflectionName = unmangledName;
           if (getterStubName) mangledNames[getterStubName] = reflectionName;
           if (isSetter) {
             reflectionName += "=";
           } else if (!isGetter) {
-            reflectionName += ":" + 
-                (requiredParameterCount + optionalParameterCount);
+            reflectionName += ":" + requiredParameterCount +
+              ":" + optionalParameterCount;
           }
           mangledNames[name] = reflectionName;
           funcs[0].$reflectionNameField = reflectionName;
           funcs[0].$metadataIndexField = unmangledNameIndex + 1;
           if (optionalParameterCount) prototype[unmangledName + "*"] = funcs[0];
         }
       }
     }
 
     #tearOffCode;
@@ skipping 90 matching lines @@
 (function() {
   var result = $array[$index];
   if ($check) {
     throw new Error(
         name + ": expected value of type \'$type\' at index " + ($index) +
         " but got " + (typeof result));
   }
   return result;
 })()''';
 }