Issue 1037223002: Move set-membership based containment test behind a flag.

Issue 1037223002: Move set-membership based containment test behind a flag. (Closed)

Created:
5 years, 9 months ago by herhut

Modified:
5 years, 8 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Move set-membership based containment test behind a flag. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=44731

Patch Set 2 : Improved comments. #

Total comments: 2

Patch Set 3 : #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -6 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/types/type_mask.dart	View	1	1 chunk	+8 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/types/union_type_mask.dart	View	1	3 chunks	+15 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

karlklose

Still LGTM. https://codereview.chromium.org/1037223002/diff/20001/pkg/compiler/lib/src/cps_ir/type_propagation.dart File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right): https://codereview.chromium.org/1037223002/diff/20001/pkg/compiler/lib/src/cps_ir/type_propagation.dart#newcode43 pkg/compiler/lib/src/cps_ir/type_propagation.dart:43: // TODO(karlklose): Remove dependency on TypeMask. Maybe ...

5 years, 9 months ago (2015-03-27 10:39:03 UTC) #4

herhut

Committed patchset #3 (id:40001) manually as 44731 (presubmit successful).

5 years, 9 months ago (2015-03-27 10:55:06 UTC) #5

herhut

5 years, 8 months ago (2015-04-01 14:02:28 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/1037223002/diff/20001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right):

https://codereview.chromium.org/1037223002/diff/20001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:43: // TODO(karlklose): Remove
dependency on TypeMask.
On 2015/03/27 10:39:03, karlklose wrote:
> Maybe remove this again.

Done.

Expand Messages | Collapse Messages