Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: pkg/compiler/lib/src/types/type_mask.dart

Issue 1037223002: Move set-membership based containment test behind a flag. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/type_propagation.dart ('k') | pkg/compiler/lib/src/types/union_type_mask.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/types/type_mask.dart
diff --git a/pkg/compiler/lib/src/types/type_mask.dart b/pkg/compiler/lib/src/types/type_mask.dart
index bb97a15392d72c02e6d26fb6e9254c586fcb1c81..a6ac4025b3474139e42e5dc101d80f3f0b3fbe04 100644
--- a/pkg/compiler/lib/src/types/type_mask.dart
+++ b/pkg/compiler/lib/src/types/type_mask.dart
@@ -200,14 +200,18 @@ abstract class TypeMask {
bool operator==(other);
/**
- * Returns `true` if [other] is a supertype of this mask, i.e., if
- * this mask is in [other].
+ * If this returns `true`, [other] is guaranteed to be a supertype of this
+ * mask, i.e., this mask is in [other]. However, the inverse does not hold.
+ * Enable [UnionTypeMask.PERFORM_EXTRA_CONTAINS_CHECK] to be notified of
+ * false negatives.
*/
bool isInMask(TypeMask other, ClassWorld classWorld);
/**
- * Returns `true` if [other] is a subtype of this mask, i.e., if
- * this mask contains [other].
+ * If this returns `true`, [other] is guaranteed to be a subtype of this mask,
+ * i.e., this mask contains [other]. However, the inverse does not hold.
+ * Enable [UnionTypeMask.PERFORM_EXTRA_CONTAINS_CHECK] to be notified of
+ * false negatives.
*/
bool containsMask(TypeMask other, ClassWorld classWorld);
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/type_propagation.dart ('k') | pkg/compiler/lib/src/types/union_type_mask.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698