Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1036943002: Add a testOn parameter to test() and group(). (Closed)

Created:
5 years, 9 months ago by nweiz
Modified:
5 years, 9 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -124 lines) Patch
M lib/src/backend/declarer.dart View 3 chunks +14 lines, -4 lines 0 comments Download
M lib/src/backend/group.dart View 3 chunks +10 lines, -2 lines 0 comments Download
M lib/src/backend/invoker.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M lib/src/backend/metadata.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M lib/src/backend/platform_selector.dart View 3 chunks +12 lines, -0 lines 0 comments Download
M lib/src/backend/suite.dart View 2 chunks +13 lines, -0 lines 0 comments Download
M lib/src/backend/test.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M lib/src/runner/browser/browser_manager.dart View 2 chunks +3 lines, -1 line 0 comments Download
M lib/src/runner/browser/iframe_listener.dart View 1 chunk +5 lines, -1 line 0 comments Download
M lib/src/runner/browser/iframe_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M lib/src/runner/loader.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M lib/src/runner/vm/isolate_listener.dart View 1 chunk +5 lines, -1 line 0 comments Download
M lib/src/runner/vm/isolate_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M lib/src/utils.dart View 2 chunks +27 lines, -0 lines 0 comments Download
M lib/unittest.dart View 3 chunks +44 lines, -6 lines 0 comments Download
M test/backend/invoker_test.dart View 28 chunks +30 lines, -26 lines 0 comments Download
M test/runner/isolate_listener_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M test/runner/test_on_test.dart View 1 chunk +173 lines, -74 lines 0 comments Download
M test/utils.dart View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 9 months ago (2015-03-25 22:42:15 UTC) #1
kevmoo
lgtm
5 years, 9 months ago (2015-03-26 22:31:50 UTC) #2
nweiz
5 years, 9 months ago (2015-03-26 22:37:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5ce2a4a96fde826b6cd242b67a70d718c4464c37 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698