Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: lib/src/runner/loader.dart

Issue 1036943002: Add a testOn parameter to test() and group(). (Closed) Base URL: git@github.com:dart-lang/unittest@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/iframe_test.dart ('k') | lib/src/runner/vm/isolate_listener.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/loader.dart
diff --git a/lib/src/runner/loader.dart b/lib/src/runner/loader.dart
index be39363383a5fcdd77eaa9dc2052c5c3ff12f6ff..ccae043a51c28d2415d194f715a772c8a69cd21a 100644
--- a/lib/src/runner/loader.dart
+++ b/lib/src/runner/loader.dart
@@ -103,8 +103,10 @@ class Loader {
if (platform == TestPlatform.chrome) return _loadBrowserFile(path);
assert(platform == TestPlatform.vm);
return _loadVmFile(path);
- }).then((suite) =>
- suite == null ? null : suite.change(metadata: metadata));
+ }).then((suite) {
+ if (suite == null) return null;
+ return suite.change(metadata: metadata).filter(platform, os: currentOS);
+ });
})).then((suites) => suites.where((suite) => suite != null).toList());
}
@@ -145,7 +147,8 @@ void main(_, Map message) {
}
return new Suite(response["tests"].map((test) {
- return new IsolateTest(test['name'], test['sendPort']);
+ var metadata = new Metadata.deserialize(test['metadata']);
+ return new IsolateTest(test['name'], metadata, test['sendPort']);
}), path: path, platform: "VM");
});
}
« no previous file with comments | « lib/src/runner/browser/iframe_test.dart ('k') | lib/src/runner/vm/isolate_listener.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698