Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Issue 1035943005: Clean up observatory testing processes when we are done with them. (Closed)

Created:
5 years, 9 months ago by turnidge
Modified:
5 years, 9 months ago
Reviewers:
Cutch, Ivan Posva
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Clean up observatory testing processes when we are done with them. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=44742

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : merge #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M runtime/bin/vmservice/vmservice_io.dart View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M runtime/observatory/test/test_helper.dart View 1 2 3 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
turnidge
5 years, 9 months ago (2015-03-26 19:27:41 UTC) #2
Cutch
lgtm
5 years, 9 months ago (2015-03-27 00:00:05 UTC) #3
Ivan Posva
DBC -ip https://codereview.chromium.org/1035943005/diff/20001/runtime/bin/vmservice/vmservice_io.dart File runtime/bin/vmservice/vmservice_io.dart (right): https://codereview.chromium.org/1035943005/diff/20001/runtime/bin/vmservice/vmservice_io.dart#newcode35 runtime/bin/vmservice/vmservice_io.dart:35: print("Error in vm-service: $e\n$st\nExiting..."); How about "Error ...
5 years, 9 months ago (2015-03-27 07:51:36 UTC) #5
turnidge
https://codereview.chromium.org/1035943005/diff/20001/runtime/bin/vmservice/vmservice_io.dart File runtime/bin/vmservice/vmservice_io.dart (right): https://codereview.chromium.org/1035943005/diff/20001/runtime/bin/vmservice/vmservice_io.dart#newcode35 runtime/bin/vmservice/vmservice_io.dart:35: print("Error in vm-service: $e\n$st\nExiting..."); On 2015/03/27 07:51:36, Ivan Posva ...
5 years, 9 months ago (2015-03-27 16:01:37 UTC) #6
turnidge
5 years, 9 months ago (2015-03-27 16:09:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 44742 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698