Clean up observatory testing processes when we are done with them.

runtime/observatory/test/test_helper.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test_helper;
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 import 'package:unittest/unittest.dart';
@@ skipping 43 matching lines @@
           first = false;
           print('** Signaled to run test queries on $portNumber');
         }
         print(line);
       });
       process.stderr.transform(UTF8.decoder)
                     .transform(new LineSplitter()).listen((line) {
         print(line);
       });
       process.exitCode.then((exitCode) {
-        expect(exitCode, equals(0));
+        print("** Process exited");
       });
       return completer.future;
     });
   }
 
   void requestExit() {
-    print('** Requesting script to exit.');
-    process.stdin.add([32, 13, 10]);
+    print('** Killing script');
+    process.kill();
   }
 }
 
 typedef Future IsolateTest(Isolate isolate);
 typedef Future VMTest(VM vm);
 
 /// Runs [tests] in sequence, each of which should take an [Isolate] and
 /// return a [Future]. Code for setting up state can run before and/or
 /// concurrently with the tests. Uses [mainArgs] to determine whether
 /// to run tests or testee in this invokation of the script.
 void runIsolateTests(List<String> mainArgs,
                      List<IsolateTest> tests,
                      {void testeeBefore(),
                       void testeeConcurrent(),
                       bool pause_on_exit}) {
   if (mainArgs.contains(_TESTEE_MODE_FLAG)) {
     if (testeeBefore != null) {
       testeeBefore();
     }
     print(''); // Print blank line to signal that we are ready.
     if (testeeConcurrent != null) {
       testeeConcurrent();
     }
-    // Wait until signaled from spawning test.
+    // Wait around for the process to be killed.
     stdin.first.then((_) => exit(0));
   } else {
     var process = new _TestLauncher();
     process.launch(pause_on_exit).then((port) {
       String addr = 'ws://localhost:$port/ws';
       var testIndex = 0;
       var totalTests = tests.length - 1;
       var name = Platform.script.pathSegments.last;
       new WebSocketVM(new WebSocketVMTarget(addr)).load()
           .then((VM vm) => vm.isolates.first.load())
           .then((Isolate isolate) => Future.forEach(tests, (test) {
             print('Running $name [$testIndex/$totalTests]');
             testIndex++;
             return test(isolate);
-          })).then((_) => exit(0));
+          })).then((_) => process.requestExit());
     });
   }
 }
 
 
 // Cancel the subscription and complete the completer when finished processing
 // events.
 typedef void ServiceEventHandler(ServiceEvent event,
                                  StreamSubscription subscription,
                                  Completer completer);
@@ skipping 18 matching lines @@
                    Future testeeConcurrent(),
                    bool pause_on_exit}) async {
   if (mainArgs.contains(_TESTEE_MODE_FLAG)) {
     if (testeeBefore != null) {
       await testeeBefore();
     }
     print(''); // Print blank line to signal that we are ready.
     if (testeeConcurrent != null) {
       await testeeConcurrent();
     }
-    // Wait until signaled from spawning test.
+    // Wait around for the process to be killed.
     stdin.first.then((_) => exit(0));
   } else {
     var process = new _TestLauncher();
     process.launch(pause_on_exit).then((port) async {
       String addr = 'ws://localhost:$port/ws';
       var testIndex = 0;
       var totalTests = tests.length - 1;
       var name = Platform.script.pathSegments.last;
       new WebSocketVM(new WebSocketVMTarget(addr)).load()
           .then((VM vm) => Future.forEach(tests, (test) {
             print('Running $name [$testIndex/$totalTests]');
             testIndex++;
             return test(vm);
-          })).then((_) => exit(0));
+          })).then((_) => process.requestExit());
     });
   }
-}
+}