Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1035283002: only suggest types when completing from a library prefix in parameter list (Closed)

Created:
5 years, 9 months ago by danrubel
Modified:
5 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

only suggest types when completing from a library prefix in parameter list BUG=dartbug.com/22526 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44756

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -8 lines) Patch
M pkg/analysis_server/lib/src/services/completion/combinator_computer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/invocation_computer.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 3 chunks +10 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 9 months ago (2015-03-27 19:37:03 UTC) #2
scheglov
LGTM
5 years, 9 months ago (2015-03-27 19:38:53 UTC) #3
danrubel
5 years, 9 months ago (2015-03-27 19:39:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44756 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698