Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1030103004: Implement ResolvedVisitor using SemanticSendVisitor. (Closed)

Created:
5 years, 9 months ago by Johnni Winther
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Implement ResolvedVisitor using SemanticSendVisitor. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=44711

Patch Set 1 #

Patch Set 2 : Cleanups. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+998 lines, -314 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart2jslib.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/placeholder_collector.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 1 229 chunks +261 lines, -254 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 22 chunks +44 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolved_visitor.dart View 1 chunk +659 lines, -34 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 9 chunks +14 lines, -14 lines 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/minify_many_locals_test.dart View 1 1 chunk +9 lines, -3 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
5 years, 9 months ago (2015-03-25 11:57:06 UTC) #2
karlklose
LGTM.
5 years, 9 months ago (2015-03-26 14:02:41 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 44711 (presubmit successful).
5 years, 9 months ago (2015-03-26 14:50:12 UTC) #4
Siggi Cherem (dart-lang)
https://codereview.chromium.org/1030103004/diff/20001/tests/compiler/dart2js/minify_many_locals_test.dart File tests/compiler/dart2js/minify_many_locals_test.dart (right): https://codereview.chromium.org/1030103004/diff/20001/tests/compiler/dart2js/minify_many_locals_test.dart#newcode14 tests/compiler/dart2js/minify_many_locals_test.dart:14: const int NUMBER_OF_PARAMETERS = 1250; FYI - this test ...
5 years, 8 months ago (2015-04-13 17:44:34 UTC) #6
Siggi Cherem (dart-lang)
5 years, 8 months ago (2015-04-13 17:46:48 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1030103004/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/minify_many_locals_test.dart (right):

https://codereview.chromium.org/1030103004/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/minify_many_locals_test.dart:14: const int
NUMBER_OF_PARAMETERS = 1250;
On 2015/04/13 17:44:34, Siggi Cherem (dart-lang) wrote:
> FYI - this test is failing for me locally with a stack overflow if I run it
> without --checked.
> 
> it seems to pass with 1185. 

I went ahead and filed https://code.google.com/p/dart/issues/detail?id=23186 to
track

Powered by Google App Engine
This is Rietveld 408576698