Chromium Code Reviews| Index: tests/compiler/dart2js/minify_many_locals_test.dart |
| diff --git a/tests/compiler/dart2js/minify_many_locals_test.dart b/tests/compiler/dart2js/minify_many_locals_test.dart |
| index b1379ae612b0e6033148ce01f7f5a7f5f7c6495e..75345a4279ba86b00980498b48ce61fdd99c96d0 100644 |
| --- a/tests/compiler/dart2js/minify_many_locals_test.dart |
| +++ b/tests/compiler/dart2js/minify_many_locals_test.dart |
| @@ -7,17 +7,23 @@ import 'package:async_helper/async_helper.dart'; |
| import 'package:expect/expect.dart'; |
| import 'compiler_helper.dart'; |
| +// TODO(johnniwinther): This value is some what arbitrary. With the old |
| +// [ResolvedVisitor] we could handle 2000, with the new [ResolvedVisitor] build |
| +// upon the [SemanticVisitor] we can handle <1300. Update (increase) the value |
| +// when the [SssBuilder] is no longer build upon the [ResolvedVisitor] . |
| +const int NUMBER_OF_PARAMETERS = 1250; |
|
Siggi Cherem (dart-lang)
2015/04/13 17:44:34
FYI - this test is failing for me locally with a s
Siggi Cherem (dart-lang)
2015/04/13 17:46:47
I went ahead and filed https://code.google.com/p/d
|
| + |
| main() { |
| var buffer = new StringBuffer(); |
| buffer.write("foo("); |
| - for (int i = 0; i < 2000; i++) { |
| + for (int i = 0; i < NUMBER_OF_PARAMETERS; i++) { |
| buffer.write("x$i, "); |
| } |
| buffer.write("x) { int i = "); |
| - for (int i = 0; i < 2000; i++) { |
| + for (int i = 0; i < NUMBER_OF_PARAMETERS; i++) { |
| buffer.write("x$i+"); |
| } |
| - buffer.write("2000; return i; }"); |
| + buffer.write("$NUMBER_OF_PARAMETERS; return i; }"); |
| String code = buffer.toString(); |
| asyncTest(() => compile(code, entry: 'foo', minify: true) |