Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1025903002: improve parser recovery of type argument list (Closed)

Created:
5 years, 9 months ago by danrubel
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

improve parser recovery of type argument list BUG= R=brianwilkerson@google.com, paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=44626

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : cleanup and fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M pkg/analysis_server/lib/src/services/completion/optype.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_target_test.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
danrubel
5 years, 9 months ago (2015-03-22 03:14:49 UTC) #2
Brian Wilkerson
LGTM
5 years, 9 months ago (2015-03-22 15:45:29 UTC) #4
Paul Berry
lgtm
5 years, 9 months ago (2015-03-22 15:53:26 UTC) #5
danrubel
5 years, 9 months ago (2015-03-22 18:33:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 44626 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698