Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: pkg/analysis_server/lib/src/services/completion/optype.dart

Issue 1025903002: improve parser recovery of type argument list (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: cleanup and fix test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/completion_target_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/completion/optype.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/optype.dart b/pkg/analysis_server/lib/src/services/completion/optype.dart
index 72c6e2218e2a75efd4b9a7288470c3f9da6337ea..213ef10cb22aed51a1a4c1092ced4d4be5985a75 100644
--- a/pkg/analysis_server/lib/src/services/completion/optype.dart
+++ b/pkg/analysis_server/lib/src/services/completion/optype.dart
@@ -139,22 +139,6 @@ class _OpTypeAstVisitor extends GeneralizingAstVisitor {
@override
void visitBinaryExpression(BinaryExpression node) {
if (identical(entity, node.rightOperand)) {
- // An empty type argument list is parsed as a binary expression
- // `C<>` is parsed as `C < `
- Object entity = this.entity;
- if (entity is SimpleIdentifier && entity.isSynthetic) {
- Token operator = node.operator;
- if (operator != null && operator.lexeme == '<') {
- Token next = entity.token.next;
- if (next is StringToken && next.lexeme.length == 0) {
- next = next.next;
- }
- if (next != null && next.lexeme == '>') {
- optype.includeTypeNameSuggestions = true;
- return;
- }
- }
- }
optype.includeReturnValueSuggestions = true;
optype.includeTypeNameSuggestions = true;
}
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/completion_target_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698