Make unittests work on Windows (again)

Make unittests work on Windows (again)

BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44680

[Johnni Winther, 2015-03-24 10:52:24]

johnniwinther@google.com changed reviewers:
+ floitsch@google.com

[Johnni Winther, 2015-03-24 10:52:24]

https://codereview.chromium.org/1024463007/diff/1/sdk/bin/pub.bat
File sdk/bin/pub.bat (left):

https://codereview.chromium.org/1024463007/diff/1/sdk/bin/pub.bat#oldcode38
sdk/bin/pub.bat:38: set PUB="%SDK_DIR%\lib\_internal\pub.dart"
nweiz@, rnystrom@: Why has this not been tested on Windows?

[floitsch, 2015-03-24 16:22:07]

LGTM.

[Bob Nystrom, 2015-03-24 16:30:42]

rnystrom@google.com changed reviewers:
+ rnystrom@google.com

[Bob Nystrom, 2015-03-24 16:30:42]

https://codereview.chromium.org/1024463007/diff/1/sdk/bin/pub.bat
File sdk/bin/pub.bat (left):

https://codereview.chromium.org/1024463007/diff/1/sdk/bin/pub.bat#oldcode38
sdk/bin/pub.bat:38: set PUB="%SDK_DIR%\lib\_internal\pub.dart"
On 2015/03/24 10:52:24, Johnni Winther wrote:
> nweiz@, rnystrom@: Why has this not been tested on Windows?

We generally do try to locally test Windows-only changes, but it's not easy to
do. We only have one Windows machine and it's crushingly slow and takes forever
(hours) to get the latest code.

Note that this batch file is only used by Dart developers running directly from
the Dart source repo. End users run pub_sdk.bat which gets renamed to pub.bat
and shipped in the actual SDK.

[Johnni Winther, 2015-03-25 07:48:31]

https://codereview.chromium.org/1024463007/diff/1/sdk/bin/pub.bat
File sdk/bin/pub.bat (left):

https://codereview.chromium.org/1024463007/diff/1/sdk/bin/pub.bat#oldcode38
sdk/bin/pub.bat:38: set PUB="%SDK_DIR%\lib\_internal\pub.dart"
On 2015/03/24 16:30:42, Bob Nystrom wrote:
> On 2015/03/24 10:52:24, Johnni Winther wrote:
> > nweiz@, rnystrom@: Why has this not been tested on Windows?
> 
> We generally do try to locally test Windows-only changes, but it's not easy to
> do. We only have one Windows machine and it's crushingly slow and takes
forever
> (hours) to get the latest code.
> 
> Note that this batch file is only used by Dart developers running directly
from
> the Dart source repo. End users run pub_sdk.bat which gets renamed to pub.bat
> and shipped in the actual SDK.

Acknowledged. Hope pub_sdk.bat is tested better then.

[Johnni Winther, 2015-03-25 07:59:53]

Committed patchset #1 (id:1) manually as 44680 (presubmit successful).

[Bob Nystrom, 2015-03-25 16:06:39]

On 2015/03/25 07:48:31, Johnni Winther wrote:
> https://codereview.chromium.org/1024463007/diff/1/sdk/bin/pub.bat
> File sdk/bin/pub.bat (left):
> 
> https://codereview.chromium.org/1024463007/diff/1/sdk/bin/pub.bat#oldcode38
> sdk/bin/pub.bat:38: set PUB="%SDK_DIR%\lib\_internal\pub.dart"
> On 2015/03/24 16:30:42, Bob Nystrom wrote:
> > On 2015/03/24 10:52:24, Johnni Winther wrote:
> > > nweiz@, rnystrom@: Why has this not been tested on Windows?
> > 
> > We generally do try to locally test Windows-only changes, but it's not easy
to
> > do. We only have one Windows machine and it's crushingly slow and takes
> forever
> > (hours) to get the latest code.
> > 
> > Note that this batch file is only used by Dart developers running directly
> from
> > the Dart source repo. End users run pub_sdk.bat which gets renamed to
pub.bat
> > and shipped in the actual SDK.
> 
> Acknowledged. Hope pub_sdk.bat is tested better then.

real_version_test invokes it. I think other tests may too, but I'm not 100%
positive.

- bob