Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: tests/compiler/dart2js/source_map_pub_build_validity_test.dart

Issue 1024463007: Make unittests work on Windows (again) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/bin/pub.bat ('K') | « tests/compiler/dart2js/dart2js_batch2_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/source_map_pub_build_validity_test.dart
diff --git a/tests/compiler/dart2js/source_map_pub_build_validity_test.dart b/tests/compiler/dart2js/source_map_pub_build_validity_test.dart
index 46b671edac6ef68c4ad57df004e606334e0759ea..939f9a233d3afc4f776c88b98409e02c1cd0243a 100644
--- a/tests/compiler/dart2js/source_map_pub_build_validity_test.dart
+++ b/tests/compiler/dart2js/source_map_pub_build_validity_test.dart
@@ -6,7 +6,7 @@ import 'dart:io';
import 'package:path/path.dart' as path;
import 'package:async_helper/async_helper.dart';
-
+import 'package:expect/expect.dart';
import 'source_map_validator_helper.dart';
void main() {
@@ -22,8 +22,10 @@ void main() {
String file = path.join(tmpDir.path, 'build/web/sunflower.dart.js');
print("Running '$command build --mode=debug' from '${tmpDir}'.");
return Process.run(command, ['build','--mode=debug'],
- workingDirectory: tmpDir.path).then((process) {
- print(process.stdout);
+ workingDirectory: tmpDir.path).then((ProcessResult processResult) {
+ print(processResult.stdout);
+ print(processResult.stderr);
+ Expect.equals(0, processResult.exitCode, 'Unexpected exitCode from pub');
validateSourceMap(new Uri.file(file, windows: Platform.isWindows));
print("Deleting '${tmpDir.path}'.");
tmpDir.deleteSync(recursive: true);
« sdk/bin/pub.bat ('K') | « tests/compiler/dart2js/dart2js_batch2_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698