Issue 102283004: Fix invalid aliasing in type propagation of AssertAssignable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 102283004: Fix invalid aliasing in type propagation of AssertAssignable. (Closed)

Created:
7 years ago by Florian Schneider

Modified:
7 years ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix invalid aliasing in type propagation of AssertAssignable. We have to create a copy when computing the initial type for AssertAssignable instead of using the CompileType of the input operand. Aliasing can cause invalid elimination of checks after strengthening of asserts. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31227

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	runtime/vm/flow_graph_type_propagator.cc	View		2 chunks	+9 lines, -1 line	0 comments	Download
	M	runtime/vm/intermediate_language.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

This fixes the crash due to illegally eliminated check-smi instructions in tests/language/assert_assignable_type_test, but propagates type ...

7 years ago (2013-12-18 15:01:18 UTC) #1

Florian Schneider

7 years ago (2013-12-18 15:30:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r31227 (presubmit successful).

Expand Messages | Collapse Messages