Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 102283004: Fix invalid aliasing in type propagation of AssertAssignable. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_type_propagator.cc
===================================================================
--- runtime/vm/flow_graph_type_propagator.cc (revision 31223)
+++ runtime/vm/flow_graph_type_propagator.cc (working copy)
@@ -758,7 +758,7 @@
CompileType* value_type = value()->Type();
if (value_type->IsMoreSpecificThan(dst_type())) {
- return value_type;
+ return ZoneCompileType::Wrap(*value_type);
}
if (dst_type().IsVoidType()) {
@@ -770,6 +770,14 @@
}
+bool AssertAssignableInstr::RecomputeType() {
+ CompileType* value_type = value()->Type();
+ return UpdateType(value_type->IsMoreSpecificThan(dst_type())
+ ? *value_type
+ : CompileType::FromAbstractType(dst_type()));
+}
+
+
CompileType AssertBooleanInstr::ComputeType() const {
return CompileType::Bool();
}
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698