Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1021813002: Redo "Use an explicit 'this' parameter instead of 'This' nodes." (Closed)

Created:
5 years, 9 months ago by sra1
Modified:
5 years, 9 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org, Johnni Winther
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Redo "Use an explicit 'this' parameter instead of 'This' nodes." BUG= Committed: https://code.google.com/p/dart/source/detail?r=44599

Patch Set 1 #

Patch Set 2 : fix analyzer2dart errors #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+354 lines, -238 lines) Patch
M pkg/analyzer2dart/lib/src/modely.dart View 1 2 chunks +7 lines, -1 line 0 comments Download
M pkg/analyzer2dart/test/sexpr_data.dart View 91 chunks +103 lines, -103 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 13 chunks +62 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart View 1 chunk +17 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 11 chunks +11 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 5 chunks +16 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 2 chunks +0 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 10 chunks +44 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_integrity.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_constprop_test.dart View 17 chunks +17 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_redundant_phi_test.dart View 8 chunks +8 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_shrinking_test.dart View 18 chunks +23 lines, -23 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart View 3 chunks +26 lines, -2 lines 0 comments Download
M tests/language/parameter_initializer_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
sra1
Retrying to fix analyze2dart errors
5 years, 9 months ago (2015-03-19 22:25:18 UTC) #2
sra1
5 years, 9 months ago (2015-03-20 10:11:24 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 44599 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698