Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

Issue 1021813002: Redo "Use an explicit 'this' parameter instead of 'This' nodes." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.ir_builder_task; 5 library dart2js.ir_builder_task;
6 6
7 import '../closure.dart' as closurelib; 7 import '../closure.dart' as closurelib;
8 import '../closure.dart' hide ClosureScope; 8 import '../closure.dart' hide ClosureScope;
9 import '../constants/expressions.dart'; 9 import '../constants/expressions.dart';
10 import '../dart_types.dart'; 10 import '../dart_types.dart';
(...skipping 1258 matching lines...) Expand 10 before | Expand all | Expand 10 after
1269 1269
1270 List<ir.Primitive> normalizeDynamicArguments( 1270 List<ir.Primitive> normalizeDynamicArguments(
1271 Selector selector, 1271 Selector selector,
1272 List<ir.Primitive> arguments) { 1272 List<ir.Primitive> arguments) {
1273 return arguments; 1273 return arguments;
1274 } 1274 }
1275 1275
1276 @override 1276 @override
1277 ir.Primitive buildReifyTypeVariable(ir.Primitive target, 1277 ir.Primitive buildReifyTypeVariable(ir.Primitive target,
1278 TypeVariableType variable) { 1278 TypeVariableType variable) {
1279 assert(target is ir.This); 1279 //assert(target == irBuilder.state.thisParameter);
1280 assert(target == irBuilder.state.enclosingMethodThisParameter);
1280 ir.Primitive prim = new ir.ReifyTypeVar(variable.element); 1281 ir.Primitive prim = new ir.ReifyTypeVar(variable.element);
1281 irBuilder.add(new ir.LetPrim(prim)); 1282 irBuilder.add(new ir.LetPrim(prim));
1282 return prim; 1283 return prim;
1283 } 1284 }
1284 } 1285 }
1285 1286
1286 /// IR builder specific to the JavaScript backend, coupled to the [JsIrBuilder]. 1287 /// IR builder specific to the JavaScript backend, coupled to the [JsIrBuilder].
1287 class JsIrBuilderVisitor extends IrBuilderVisitor { 1288 class JsIrBuilderVisitor extends IrBuilderVisitor {
1288 /// Promote the type of [irBuilder] to [JsIrBuilder]. 1289 /// Promote the type of [irBuilder] to [JsIrBuilder].
1289 JsIrBuilder get irBuilder => super.irBuilder; 1290 JsIrBuilder get irBuilder => super.irBuilder;
(...skipping 561 matching lines...) Expand 10 before | Expand all | Expand 10 after
1851 SourceInformation buildCall(ast.Node node) { 1852 SourceInformation buildCall(ast.Node node) {
1852 return new PositionSourceInformation( 1853 return new PositionSourceInformation(
1853 new TokenSourceLocation(sourceFile, node.getBeginToken(), name)); 1854 new TokenSourceLocation(sourceFile, node.getBeginToken(), name));
1854 } 1855 }
1855 1856
1856 @override 1857 @override
1857 SourceInformationBuilder forContext(AstElement element) { 1858 SourceInformationBuilder forContext(AstElement element) {
1858 return new PositionSourceInformationBuilder(element); 1859 return new PositionSourceInformationBuilder(element);
1859 } 1860 }
1860 } 1861 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698