Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1019683002: Eliminate some DebugStep calls in async code (Closed)

Created:
5 years, 9 months ago by hausner
Modified:
5 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Eliminate some DebugStep calls in async code There is no reason to check debugger stepping when assigning to internal helper variables. Committed: https://code.google.com/p/dart/source/detail?r=44577

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M runtime/vm/scopes.h View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
hausner
5 years, 9 months ago (2015-03-18 22:06:21 UTC) #2
srdjan
LGTMwC https://codereview.chromium.org/1019683002/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://codereview.chromium.org/1019683002/diff/1/runtime/vm/flow_graph_builder.cc#newcode3446 runtime/vm/flow_graph_builder.cc:3446: (node->token_pos() != Scanner::kNoSourcePos)) { How about factoring this ...
5 years, 9 months ago (2015-03-18 23:26:27 UTC) #3
hausner
Thank you. https://codereview.chromium.org/1019683002/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://codereview.chromium.org/1019683002/diff/1/runtime/vm/flow_graph_builder.cc#newcode3446 runtime/vm/flow_graph_builder.cc:3446: (node->token_pos() != Scanner::kNoSourcePos)) { On 2015/03/18 23:26:27, ...
5 years, 9 months ago (2015-03-18 23:59:21 UTC) #4
hausner
5 years, 9 months ago (2015-03-19 16:54:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r44577 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698