Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 1019683002: Eliminate some DebugStep calls in async code (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/scopes.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 44565)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -3436,10 +3436,13 @@
void EffectGraphVisitor::VisitStoreLocalNode(StoreLocalNode* node) {
// If the right hand side is an expression that does not contain
// a safe point for the debugger to stop, add an explicit stub
- // call.
- if (node->value()->IsLiteralNode() ||
+ // call. Exception: don't do this when assigning to internal variables,
+ // or for generated code that has no source position.
+ if ((node->value()->IsLiteralNode() ||
node->value()->IsLoadLocalNode() ||
- node->value()->IsClosureNode()) {
+ node->value()->IsClosureNode()) &&
+ node->local().IsInternal() &&
+ (node->token_pos() != Scanner::kNoSourcePos)) {
AddInstruction(new(Z) DebugStepCheckInstr(
node->token_pos(), RawPcDescriptors::kRuntimeCall));
}
« no previous file with comments | « no previous file | runtime/vm/scopes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698