Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1018403002: Revert "Use an explicit 'this' parameter instead of 'This' nodes." (Closed)

Created:
5 years, 9 months ago by sra1
Modified:
5 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Revert "Use an explicit 'this' parameter instead of 'This' nodes." Committed: https://code.google.com/p/dart/source/detail?r=44581

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -338 lines) Patch
M pkg/analyzer2dart/test/sexpr_data.dart View 91 chunks +103 lines, -103 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 13 chunks +8 lines, -53 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart View 1 chunk +2 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 11 chunks +16 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 5 chunks +8 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 10 chunks +28 lines, -44 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_integrity.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_constprop_test.dart View 17 chunks +17 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_redundant_phi_test.dart View 8 chunks +8 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_shrinking_test.dart View 18 chunks +23 lines, -23 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_test.dart View 1 chunk +1 line, -4 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart View 3 chunks +2 lines, -26 lines 0 comments Download
M tests/language/parameter_initializer_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
sra1
Committed patchset #1 (id:1) manually as 44581 (presubmit successful).
5 years, 9 months ago (2015-03-19 18:01:36 UTC) #1
karlklose
5 years, 9 months ago (2015-03-20 08:27:08 UTC) #3
Message was sent while issue was closed. 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698