Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: pkg/compiler/lib/src/cps_ir/type_propagation.dart

Issue 1018403002: Revert "Use an explicit 'this' parameter instead of 'This' nodes." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/type_propagation.dart
diff --git a/pkg/compiler/lib/src/cps_ir/type_propagation.dart b/pkg/compiler/lib/src/cps_ir/type_propagation.dart
index bd723fc1f0a17f132dcec9f080823ff8acec9239..bdacd015367b857e01c2152b372cbf76ea9f7d32 100644
--- a/pkg/compiler/lib/src/cps_ir/type_propagation.dart
+++ b/pkg/compiler/lib/src/cps_ir/type_propagation.dart
@@ -422,9 +422,6 @@ class _TypePropagationVisitor<T> implements Visitor {
}
void visitFunctionDefinition(FunctionDefinition node) {
- if (node.thisParameter != null) {
- setValue(node.thisParameter, nonConst());
- }
node.parameters.forEach(visit);
setReachable(node.body);
}
@@ -728,6 +725,11 @@ class _TypePropagationVisitor<T> implements Visitor {
setValue(node, constantValue(value, typeSystem.typeOf(value)));
}
+ void visitThis(This node) {
+ // TODO(karlklose): Add the type.
+ setValue(node, nonConst());
+ }
+
void visitReifyTypeVar(ReifyTypeVar node) {
setValue(node, nonConst(typeSystem.typeType));
}
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart ('k') | pkg/compiler/lib/src/dart_backend/backend.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698