Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1014503004: Issue 22834. Disable 'Add type annotation' Quick Assist if the type is not accessible. (Closed)

Created:
5 years, 9 months ago by scheglov
Modified:
5 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Issue 22834. Disable 'Add type annotation' Quick Assist if the type is not accessible. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=22834 Committed: https://code.google.com/p/dart/source/detail?r=44509

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 3 chunks +15 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/util.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 2 chunks +68 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 9 months ago (2015-03-16 15:24:21 UTC) #1
Brian Wilkerson
LGTM
5 years, 9 months ago (2015-03-16 15:26:13 UTC) #2
scheglov
5 years, 9 months ago (2015-03-16 15:27:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44509 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698