Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Unified Diff: pkg/analysis_server/test/services/correction/assist_test.dart

Issue 1014503004: Issue 22834. Disable 'Add type annotation' Quick Assist if the type is not accessible. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/util.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/correction/assist_test.dart
diff --git a/pkg/analysis_server/test/services/correction/assist_test.dart b/pkg/analysis_server/test/services/correction/assist_test.dart
index 15f68bec5db38cfa78c3cdebf772b9fc7d6b64ce..16feba7e7854d74182a450836bf20967af070e7a 100644
--- a/pkg/analysis_server/test/services/correction/assist_test.dart
+++ b/pkg/analysis_server/test/services/correction/assist_test.dart
@@ -97,6 +97,57 @@ class AssistProcessorTest extends AbstractSingleUnitTest {
length = 0;
}
+ void test_addTypeAnnotation_BAD_privateType_closureParameter() {
+ addSource('/my_lib.dart', '''
+library my_lib;
+class A {}
+class _B extends A {}
+foo(f(_B p)) {}
+''');
+ resolveTestUnit('''
+import 'my_lib.dart';
+main() {
+ foo((test) {});
+}
+ ''');
+ assertNoAssistAt('test)', AssistKind.ADD_TYPE_ANNOTATION);
+ }
+
+ void test_addTypeAnnotation_BAD_privateType_declaredIdentifier() {
+ addSource('/my_lib.dart', '''
+library my_lib;
+class A {}
+class _B extends A {}
+List<_B> getValues() => [];
+''');
+ resolveTestUnit('''
+import 'my_lib.dart';
+class A<T> {
+ main() {
+ for (var item in getValues()) {
+ }
+ }
+}
+''');
+ assertNoAssistAt('var item', AssistKind.ADD_TYPE_ANNOTATION);
+ }
+
+ void test_addTypeAnnotation_BAD_privateType_variable() {
+ addSource('/my_lib.dart', '''
+library my_lib;
+class A {}
+class _B extends A {}
+_B getValue() => new _B();
+''');
+ resolveTestUnit('''
+import 'my_lib.dart';
+main() {
+ var v = getValue();
+}
+''');
+ assertNoAssistAt('var ', AssistKind.ADD_TYPE_ANNOTATION);
+ }
+
void test_addTypeAnnotation_classField_OK_final() {
resolveTestUnit('''
class A {
@@ -520,6 +571,23 @@ main() {
assertNoAssistAt('var ', AssistKind.ADD_TYPE_ANNOTATION);
}
+ void test_addTypeAnnotation_OK_privateType_sameLibrary() {
+ resolveTestUnit('''
+class _A {}
+_A getValue() => new _A();
+main() {
+ var v = getValue();
+}
+''');
+ assertHasAssistAt('var ', AssistKind.ADD_TYPE_ANNOTATION, '''
+class _A {}
+_A getValue() => new _A();
+main() {
+ _A v = getValue();
+}
+''');
+ }
+
void test_addTypeAnnotation_parameter_BAD_hasExplicitType() {
resolveTestUnit('''
foo(f(int p)) {}
« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/util.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698