Support publishing packages with many long filenames.

Support publishing packages with many long filenames.

R=rnystrom@google.com
BUG= dartbug.com/22878

Committed: https://code.google.com/p/dart/source/detail?r=44652

[Bob Nystrom, 2015-03-23 23:19:16]

https://codereview.chromium.org/1013423003/diff/1/sdk/lib/_internal/pub/lib/s...
File sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.chromium.org/1013423003/diff/1/sdk/lib/_internal/pub/lib/s...
sdk/lib/_internal/pub/lib/src/io.dart:936: return new
ByteStream(futureStream(new Future.sync(() async {
Is the new Future.sync() still needed?

https://codereview.chromium.org/1013423003/diff/1/sdk/lib/_internal/pub/lib/s...
sdk/lib/_internal/pub/lib/src/io.dart:954: "/dev/stdin"];
Nit:

var args = [
  "--create",
  ...
];

https://codereview.chromium.org/1013423003/diff/1/sdk/lib/_internal/pub/lib/s...
sdk/lib/_internal/pub/lib/src/io.dart:958: // for 7zip.
TODONE.

https://codereview.chromium.org/1013423003/diff/1/sdk/lib/_internal/pub/lib/s...
sdk/lib/_internal/pub/lib/src/io.dart:972:
.writeAsStringSync(contents.join("\n"));
writeTextFile() in io.dart.

https://codereview.chromium.org/1013423003/diff/1/sdk/lib/_internal/pub/lib/s...
sdk/lib/_internal/pub/lib/src/io.dart:977: args.addAll(contents.map((entry) =>
'-i!$entry'));
I'm guessing you want to change this too?

[nweiz, 2015-03-23 23:42:12]

Code review changes

[nweiz, 2015-03-23 23:42:26]

https://codereview.chromium.org/1013423003/diff/1/sdk/lib/_internal/pub/lib/s...
File sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.chromium.org/1013423003/diff/1/sdk/lib/_internal/pub/lib/s...
sdk/lib/_internal/pub/lib/src/io.dart:936: return new
ByteStream(futureStream(new Future.sync(() async {
On 2015/03/23 23:19:16, Bob Nystrom wrote:
> Is the new Future.sync() still needed?

Yeah; we need to pass a Future to [futureStream]. It could be "(() async { ...
})()", but that seems less clear to me.

https://codereview.chromium.org/1013423003/diff/1/sdk/lib/_internal/pub/lib/s...
sdk/lib/_internal/pub/lib/src/io.dart:954: "/dev/stdin"];
On 2015/03/23 23:19:15, Bob Nystrom wrote:
> Nit:
> 
> var args = [
>   "--create",
>   ...
> ];

Done.

https://codereview.chromium.org/1013423003/diff/1/sdk/lib/_internal/pub/lib/s...
sdk/lib/_internal/pub/lib/src/io.dart:958: // for 7zip.
On 2015/03/23 23:19:16, Bob Nystrom wrote:
> TODONE.

Done.

https://codereview.chromium.org/1013423003/diff/1/sdk/lib/_internal/pub/lib/s...
sdk/lib/_internal/pub/lib/src/io.dart:972:
.writeAsStringSync(contents.join("\n"));
On 2015/03/23 23:19:15, Bob Nystrom wrote:
> writeTextFile() in io.dart.

Oh yeah! Pub is great.

https://codereview.chromium.org/1013423003/diff/1/sdk/lib/_internal/pub/lib/s...
sdk/lib/_internal/pub/lib/src/io.dart:977: args.addAll(contents.map((entry) =>
'-i!$entry'));
On 2015/03/23 23:19:16, Bob Nystrom wrote:
> I'm guessing you want to change this too?

Done.

[Bob Nystrom, 2015-03-23 23:55:00]

LGTM!

[nweiz, 2015-03-24 00:36:13]

Committed patchset #2 (id:20001) manually as 44652 (presubmit successful).