Support publishing packages with many long filenames.

sdk/lib/_internal/pub/lib/src/io.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Helper functionality to make working with IO easier.
 library pub.io;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:convert';
@@ skipping 915 matching lines @@
 }
 
 /// Create a .tar.gz archive from a list of entries.
 ///
 /// Each entry can be a [String], [Directory], or [File] object. The root of
 /// the archive is considered to be [baseDir], which defaults to the current
 /// working directory.
 ///
 /// Returns a [ByteStream] that emits the contents of the archive.
 ByteStream createTarGz(List contents, {baseDir}) {
-  return new ByteStream(futureStream(new Future.sync(() {
+  return new ByteStream(futureStream(new Future.sync(() async {
     var buffer = new StringBuffer();
     buffer.write('Creating .tag.gz stream containing:\n');
     contents.forEach((file) => buffer.write('$file\n'));
     log.fine(buffer.toString());
 
     if (baseDir == null) baseDir = path.current;
     baseDir = path.absolute(baseDir);
     contents = contents.map((entry) {
       entry = path.absolute(entry);
       if (!path.isWithin(baseDir, entry)) {
         throw new ArgumentError('Entry $entry is not inside $baseDir.');
       }
       return path.relative(entry, from: baseDir);
     }).toList();
 
     if (Platform.operatingSystem != "windows") {
-      var args = ["--create", "--gzip", "--directory", baseDir];
-      args.addAll(contents);
-      // TODO(nweiz): It's possible that enough command-line arguments will
-      // make the process choke, so at some point we should save the arguments
-      // to a file and pass them in via --files-from for tar and -i@filename
-      // for 7zip.
-      return startProcess("tar", args).then((process) => process.stdout);
+      var args = [
+        "--create",
+        "--gzip",
+        "--directory",
+        baseDir,
+        "--files-from",
+        "/dev/stdin"
+      ];
+
+      var process = await startProcess("tar", args);
+      process.stdin.add(UTF8.encode(contents.join("\n")));
+      process.stdin.close();
+      return process.stdout;
     }
 
     // Don't use [withTempDir] here because we don't want to delete the temp
     // directory until the returned stream has closed.
     var tempDir = createSystemTempDir();
-    return new Future.sync(() {
+
+    try {
+      // Create the file containing the list of files to compress.
+      var contentsPath = path.join(tempDir, "files.txt");
+      writeTextFile(contentsPath, contents.join("\n"));
+
       // Create the tar file.
       var tarFile = path.join(tempDir, "intermediate.tar");
-      var args = ["a", "-w$baseDir", tarFile];
-      args.addAll(contents.map((entry) => '-i!$entry'));
+      var args = ["a", "-w$baseDir", tarFile, "@$contentsPath"];
 
       // We're passing 'baseDir' both as '-w' and setting it as the working
       // directory explicitly here intentionally. The former ensures that the
       // files added to the archive have the correct relative path in the
       // archive. The latter enables relative paths in the "-i" args to be
       // resolved.
-      return runProcess(pathTo7zip, args, workingDir: baseDir).then((_) {
-        // GZIP it. 7zip doesn't support doing both as a single operation.
-        // Send the output to stdout.
-        args = ["a", "unused", "-tgzip", "-so", tarFile];
-        return startProcess(pathTo7zip, args);
-      }).then((process) => process.stdout);
-    }).then((stream) {
-      return stream.transform(onDoneTransformer(() => deleteEntry(tempDir)));
-    }).catchError((e) {
+      await runProcess(pathTo7zip, args, workingDir: baseDir);
+
+      // GZIP it. 7zip doesn't support doing both as a single operation.
+      // Send the output to stdout.
+      args = ["a", "unused", "-tgzip", "-so", tarFile];
+      return (await startProcess(pathTo7zip, args))
+          .stdout
+          .transform(onDoneTransformer(() => deleteEntry(tempDir)));
+    } catch (_) {
       deleteEntry(tempDir);
-      throw e;
-    });
+      rethrow;
+    }
   })));
 }
 
 /// Contains the results of invoking a [Process] and waiting for it to complete.
 class PubProcessResult {
   final List<String> stdout;
   final List<String> stderr;
   final int exitCode;
 
   PubProcessResult(String stdout, String stderr, this.exitCode)
       : this.stdout = _toLines(stdout),
         this.stderr = _toLines(stderr);
 
   // TODO(rnystrom): Remove this and change to returning one string.
   static List<String> _toLines(String output) {
     var lines = splitLines(output);
     if (!lines.isEmpty && lines.last == "") lines.removeLast();
     return lines;
   }
 
   bool get success => exitCode == exit_codes.SUCCESS;
 }
 
 /// Gets a [Uri] for [uri], which can either already be one, or be a [String].
 Uri _getUri(uri) {
   if (uri is Uri) return uri;
   return Uri.parse(uri);
 }