Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1012333002: Keep zone cached in SnapshotReader to allow removing ZoneHandle(Isolate*) interface. (Closed)

Created:
5 years, 9 months ago by koda
Modified:
5 years, 9 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Keep zone cached in SnapshotReader to allow removing ZoneHandle(Isolate*) interface. Add a StackZone around API snapshot reading call. Also remove CheckedHandle(Isolate*) interface by migrating its users to Zone*. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44580

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 2

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -174 lines) Patch
M runtime/lib/class_id.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/function.cc View 1 2 3 4 5 6 7 3 chunks +8 lines, -8 lines 0 comments Download
M runtime/lib/object.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -6 lines 0 comments Download
M runtime/lib/string.cc View 1 2 3 4 5 6 7 8 chunks +10 lines, -10 lines 0 comments Download
M runtime/vm/benchmark_test.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -3 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 2 3 4 5 6 7 4 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/constant_propagator.cc View 1 2 3 4 5 6 7 9 chunks +12 lines, -12 lines 0 comments Download
M runtime/vm/dart.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 3 4 5 6 7 3 chunks +9 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/isolate.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 3 4 5 6 7 4 chunks +11 lines, -8 lines 0 comments Download
M runtime/vm/native_entry.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/native_entry_test.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/object.h View 1 2 3 4 5 6 7 5 chunks +4 lines, -28 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 2 3 4 5 6 7 42 chunks +42 lines, -44 lines 0 comments Download
M runtime/vm/service_isolate.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -3 lines 0 comments Download
M runtime/vm/service_test.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/snapshot.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/snapshot.cc View 1 2 3 4 5 6 7 7 chunks +9 lines, -7 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 2 3 4 5 6 7 18 chunks +23 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
koda
5 years, 9 months ago (2015-03-18 00:14:45 UTC) #1
koda
FYI, the only place where this might change which zone is used, is the zone ...
5 years, 9 months ago (2015-03-18 00:18:13 UTC) #2
siva
lgtm https://codereview.chromium.org/1012333002/diff/120001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/1012333002/diff/120001/runtime/vm/dart_api_impl.cc#newcode5010 runtime/vm/dart_api_impl.cc:5010: StackZone zone(isolate); maybe we should move this after ...
5 years, 9 months ago (2015-03-19 17:29:49 UTC) #3
koda
https://codereview.chromium.org/1012333002/diff/120001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/1012333002/diff/120001/runtime/vm/dart_api_impl.cc#newcode5010 runtime/vm/dart_api_impl.cc:5010: StackZone zone(isolate); On 2015/03/19 17:29:48, siva wrote: > maybe ...
5 years, 9 months ago (2015-03-19 17:35:41 UTC) #4
koda
5 years, 9 months ago (2015-03-19 17:47:08 UTC) #5
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) manually as r44580 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698