Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: runtime/vm/object.h

Issue 1012333002: Keep zone cached in SnapshotReader to allow removing ZoneHandle(Isolate*) interface. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/native_entry_test.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h (revision 44579)
+++ runtime/vm/object.h (working copy)
@@ -93,10 +93,6 @@
} \
return *obj; \
} \
- /* DEPRECATED: Use Zone version. */ \
- static object& CheckedHandle(Isolate* isolate, RawObject* raw_ptr) { \
- return CheckedHandle(isolate->current_zone(), raw_ptr); \
- } \
static object& CheckedHandle(RawObject* raw_ptr) { \
return CheckedHandle(Thread::Current()->zone(), raw_ptr); \
} \
@@ -106,10 +102,6 @@
initializeHandle(obj, raw_ptr); \
return *obj; \
} \
- /* DEPRECATED: Use Zone version. */ \
- static object& ZoneHandle(Isolate* isolate, Raw##object* raw_ptr) { \
- return ZoneHandle(isolate->current_zone(), raw_ptr); \
- } \
static object* ReadOnlyHandle() { \
object* obj = reinterpret_cast<object*>( \
Dart::AllocateReadOnlyHandle()); \
@@ -119,10 +111,6 @@
static object& ZoneHandle(Zone* zone) { \
return ZoneHandle(zone, object::null()); \
} \
- /* DEPRECATED: Use Zone version. */ \
- static object& ZoneHandle(Isolate* isolate) { \
- return ZoneHandle(isolate->current_zone(), object::null()); \
- } \
static object& ZoneHandle() { \
return ZoneHandle(Thread::Current()->zone(), object::null()); \
} \
@@ -380,17 +368,13 @@
initializeHandle(obj, raw_ptr);
return *obj;
}
- // DEPRECATED: Use Zone version.
- static Object& ZoneHandle(Isolate* isolate, RawObject* raw_ptr) {
- return ZoneHandle(isolate->current_zone(), raw_ptr);
- }
static Object& ZoneHandle() {
- return ZoneHandle(Isolate::Current(), null_);
+ return ZoneHandle(Thread::Current()->zone(), null_);
}
static Object& ZoneHandle(RawObject* raw_ptr) {
- return ZoneHandle(Isolate::Current(), raw_ptr);
+ return ZoneHandle(Thread::Current()->zone(), raw_ptr);
}
static RawObject* null() { return null_; }
@@ -869,23 +853,15 @@
obj->set_vtable(0);
return *obj;
}
- // DEPRECATED - use Zone version.
- static PassiveObject& ZoneHandle(Isolate* I, RawObject* raw_ptr) {
- return ZoneHandle(I->current_zone(), raw_ptr);
- }
static PassiveObject& ZoneHandle(RawObject* raw_ptr) {
- return ZoneHandle(Isolate::Current(), raw_ptr);
+ return ZoneHandle(Thread::Current()->zone(), raw_ptr);
}
static PassiveObject& ZoneHandle() {
- return ZoneHandle(Isolate::Current(), Object::null());
+ return ZoneHandle(Thread::Current()->zone(), Object::null());
}
static PassiveObject& ZoneHandle(Zone* zone) {
return ZoneHandle(zone, Object::null());
}
- // DEPRECATED - use Zone version.
- static PassiveObject& ZoneHandle(Isolate* I) {
- return ZoneHandle(I->current_zone(), Object::null());
- }
private:
PassiveObject() : Object() {}
« no previous file with comments | « runtime/vm/native_entry_test.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698