Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1010403002: Ensure that stack traces are propagated more often in dart:io. (Closed)

Created:
5 years, 9 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, ahe
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Ensure that stack traces are propagated more often in dart:io. BUG= http://dartbug.com/22873 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=44551

Patch Set 1 #

Total comments: 2

Patch Set 2 : Tab to space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -50 lines) Patch
M sdk/lib/io/directory_impl.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 chunk +1 line, -3 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 4 chunks +6 lines, -10 lines 0 comments Download
M sdk/lib/io/http_parser.dart View 2 chunks +1 line, -5 lines 0 comments Download
M sdk/lib/io/io_sink.dart View 3 chunks +16 lines, -15 lines 0 comments Download
M sdk/lib/io/secure_server_socket.dart View 2 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Lasse Reichstein Nielsen
5 years, 9 months ago (2015-03-18 07:47:12 UTC) #2
ahe
I'll patch this in locally and pay attention to stack traces (or the lack thereof).
5 years, 9 months ago (2015-03-18 07:54:40 UTC) #3
Søren Gjesse
LGTM, thanks to finding all these places https://codereview.chromium.org/1010403002/diff/1/sdk/lib/io/directory_impl.dart File sdk/lib/io/directory_impl.dart (right): https://codereview.chromium.org/1010403002/diff/1/sdk/lib/io/directory_impl.dart#newcode289 sdk/lib/io/directory_impl.dart:289: } else ...
5 years, 9 months ago (2015-03-18 08:13:12 UTC) #4
Lasse Reichstein Nielsen
https://codereview.chromium.org/1010403002/diff/1/sdk/lib/io/directory_impl.dart File sdk/lib/io/directory_impl.dart (right): https://codereview.chromium.org/1010403002/diff/1/sdk/lib/io/directory_impl.dart#newcode289 sdk/lib/io/directory_impl.dart:289: } else if (response is Error) { ICK. Editor, ...
5 years, 9 months ago (2015-03-18 10:09:31 UTC) #5
Lasse Reichstein Nielsen
5 years, 9 months ago (2015-03-18 10:14:26 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 44551 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698