Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: sdk/lib/io/http_parser.dart

Issue 1010403002: Ensure that stack traces are propagated more often in dart:io. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Tab to space Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/http_impl.dart ('k') | sdk/lib/io/io_sink.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/http_parser.dart
diff --git a/sdk/lib/io/http_parser.dart b/sdk/lib/io/http_parser.dart
index d941aa40b63deef9958a9596286b596d2d55188b..09f06eaee38b5cff19d0d0095850d4c2a9ac0ddc 100644
--- a/sdk/lib/io/http_parser.dart
+++ b/sdk/lib/io/http_parser.dart
@@ -321,7 +321,7 @@ class _HttpParser extends Stream<_HttpIncoming> {
// how the _HttpIncoming signals the parser.
_socketSubscription = stream.listen(
_onData,
- onError: _onError,
+ onError: _controller.addError,
onDone: _onDone);
}
@@ -845,10 +845,6 @@ class _HttpParser extends Stream<_HttpIncoming> {
_controller.close();
}
- void _onError(e, [StackTrace stackTrace]) {
- _controller.addError(e, stackTrace);
- }
-
String get version {
switch (_httpVersion) {
case _HttpVersion.HTTP10:
« no previous file with comments | « sdk/lib/io/http_impl.dart ('k') | sdk/lib/io/io_sink.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698