Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1458)

Issue 100823005: Update the Mac OS watcher in pkg/watcher. (Closed)

Created:
7 years ago by nweiz
Modified:
7 years ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update the Mac OS watcher in pkg/watcher. The behavior of Directory.watch has changed, and this updates the watcher to match the new behavior. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -98 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/watcher/lib/src/directory_watcher/mac_os.dart View 7 chunks +31 lines, -37 lines 0 comments Download
M pkg/watcher/test/directory_watcher/mac_os_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
M pkg/watcher/test/no_subscription/mac_os_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
M pkg/watcher/test/no_subscription/shared.dart View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years ago (2013-12-05 02:16:49 UTC) #1
Bob Nystrom
lgtm
7 years ago (2013-12-05 20:16:17 UTC) #2
nweiz
7 years ago (2013-12-05 20:26:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30915 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698