Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: pkg/watcher/test/no_subscription/shared.dart

Issue 100823005: Update the Mac OS watcher in pkg/watcher. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/watcher/test/no_subscription/mac_os_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/watcher/test/no_subscription/shared.dart
diff --git a/pkg/watcher/test/no_subscription/shared.dart b/pkg/watcher/test/no_subscription/shared.dart
index de625d51d3855b72bb4bbddcb0e24732afb67057..99172a2e81b527805e0fbf9d02bafb132489b316 100644
--- a/pkg/watcher/test/no_subscription/shared.dart
+++ b/pkg/watcher/test/no_subscription/shared.dart
@@ -41,16 +41,6 @@ sharedTests() {
schedule(() {
completer = new Completer();
subscription = watcher.events.listen(wrapAsync((event) {
- // TODO(nweiz): Remove this when either issue 14373 or 14793 is fixed.
- // Issue 14373 means that the new [Directory.watch] will emit an event
- // for "unwatched.txt" being created, and issue 14793 means we have to
- // check the filesystem, which leads us to assume that the file has been
- // modified.
- if (Platform.isMacOS && event.path.endsWith("unwatched.txt")) {
- expect(event, isWatchEvent(ChangeType.MODIFY, "unwatched.txt"));
- return;
- }
-
// We should get an event for the third file, not the one added while
// we weren't subscribed.
expect(event, isWatchEvent(ChangeType.ADD, "added.txt"));
« no previous file with comments | « pkg/watcher/test/no_subscription/mac_os_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698