Issue 1007873002: Add call to deferred action method in csp constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1007873002: Add call to deferred action method in csp constructors. (Closed)

Created:
5 years, 9 months ago by herhut

Modified:
5 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Add call to deferred action method in csp constructors. BUG= TBR=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44464

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	pkg/compiler/lib/src/js_emitter/class_stub_generator.dart	View		1 chunk	+3 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

herhut

Committed patchset #1 (id:1) manually as 44464 (presubmit successful).

5 years, 9 months ago (2015-03-13 15:48:54 UTC) #2

floitsch

5 years, 9 months ago (2015-03-13 15:53:26 UTC) #3

Message was sent while issue was closed.

LGTM.

https://codereview.chromium.org/1007873002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/class_stub_generator.dart (right):

https://codereview.chromium.org/1007873002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/class_stub_generator.dart:25: fields.map((name)
=> js('this.# = #', [name, name])),
wouldn't it be better to do the deferredAction first? before initializing the
fields.

Expand Messages | Collapse Messages