Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/class_stub_generator.dart

Issue 1007873002: Add call to deferred action method in csp constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.js_emitter; 5 part of dart2js.js_emitter;
6 6
7 class ClassStubGenerator { 7 class ClassStubGenerator {
8 final Namer namer; 8 final Namer namer;
9 final Compiler compiler; 9 final Compiler compiler;
10 final JavaScriptBackend backend; 10 final JavaScriptBackend backend;
11 11
12 ClassStubGenerator(this.compiler, this.namer, this.backend); 12 ClassStubGenerator(this.compiler, this.namer, this.backend);
13 13
14 jsAst.Expression generateClassConstructor(ClassElement classElement, 14 jsAst.Expression generateClassConstructor(ClassElement classElement,
15 Iterable<String> fields) { 15 Iterable<String> fields) {
16 // TODO(sra): Implement placeholders in VariableDeclaration position: 16 // TODO(sra): Implement placeholders in VariableDeclaration position:
17 // 17 //
18 // String constructorName = namer.getNameOfClass(classElement); 18 // String constructorName = namer.getNameOfClass(classElement);
19 // return js.statement('function #(#) { #; }', 19 // return js.statement('function #(#) { #; }',
20 // [ constructorName, fields, 20 // [ constructorName, fields,
21 // fields.map( 21 // fields.map(
22 // (name) => js('this.# = #', [name, name]))])); 22 // (name) => js('this.# = #', [name, name]))]));
23 return js('function(#) { #; }', 23 return js('function(#) { #; this.#();}',
24 [fields, 24 [fields,
25 fields.map((name) => js('this.# = #', [name, name]))]); 25 fields.map((name) => js('this.# = #', [name, name])),
floitsch 2015/03/13 15:53:26 wouldn't it be better to do the deferredAction fir
26 namer.deferredAction]);
26 } 27 }
27 28
28 jsAst.Expression generateGetter(Element member, String fieldName) { 29 jsAst.Expression generateGetter(Element member, String fieldName) {
29 ClassElement cls = member.enclosingClass; 30 ClassElement cls = member.enclosingClass;
30 String receiver = backend.isInterceptorClass(cls) ? 'receiver' : 'this'; 31 String receiver = backend.isInterceptorClass(cls) ? 'receiver' : 'this';
31 List<String> args = backend.isInterceptedMethod(member) ? ['receiver'] : []; 32 List<String> args = backend.isInterceptedMethod(member) ? ['receiver'] : [];
32 return js('function(#) { return #.# }', [args, receiver, fieldName]); 33 return js('function(#) { return #.# }', [args, receiver, fieldName]);
33 } 34 }
34 35
35 jsAst.Expression generateSetter(Element member, String fieldName) { 36 jsAst.Expression generateSetter(Element member, String fieldName) {
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 ? function() { 279 ? function() {
279 if (cache === void 0) cache = #tearOff( 280 if (cache === void 0) cache = #tearOff(
280 this, funcs, reflectionInfo, true, [], name).prototype; 281 this, funcs, reflectionInfo, true, [], name).prototype;
281 return cache; 282 return cache;
282 } 283 }
283 : tearOffGetter(funcs, reflectionInfo, name, isIntercepted); 284 : tearOffGetter(funcs, reflectionInfo, name, isIntercepted);
284 }''', {'tearOff': tearOffAccessExpression}); 285 }''', {'tearOff': tearOffAccessExpression});
285 286
286 return <jsAst.Statement>[tearOffGetter, tearOff]; 287 return <jsAst.Statement>[tearOffGetter, tearOff];
287 } 288 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698