Allow Observatory debugger to switch isolates.

Allow Observatory debugger to switch isolates.

- Add the "isolate" command which allows the user to switch isolate by name or number.  Supports completion.

- Add the "isolate name" command which allows the user to rename an isolate.  Add the "setName" method to the service protocol to support this.  Isolates now have a debugger_name() in the vm.

- The new IsolateUpdate event notifies the client when an isolate name changes.

- When an isolate is updated, update the page's isolate too, so the navbar is accurate.

- Update isolate summary to display isolate number.

- Rework how the isolate's name is computed because we were getting garbagey names in the IsolateStart event (SpawnState was not yet set).

- Make sure that the debugger doesn't subscribe to events multiple times.

- "info isolates" is now "isolate list".

- Rework reporting of vm and isolate startTime in the service protocol and in Observatory.

- Fix bug in command completion when subcommands and other completions share common prefixes.

- Rework isolate accounting in the VM object in Observatory.  We now create Isolates in getFromMap rather than from IsolateStart events, per se.  Rewrite the isolate updating code.

- IsolateStart and IsolateExit events are now owned by the Isolate itself, rather than the vm.

- Return the actual result in pause/resume/etc.

- Add assertion in JSONStream::PrintProperty64 that the result fits in a javascript double.  Sigh.

- Stop sending GC events for the service isolate.  Add assertions to guard against this happening in the future.

- Misc improvements in error reporting.

Committed: https://code.google.com/p/dart/source/detail?r=44718

[turnidge, 2015-03-18 18:29:49]

turnidge@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2015-03-18 20:05:48]

LGTMwC

https://codereview.chromium.org/1007863003/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/1007863003/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/service/object.dart:577:
_updateIsolates(map['isolates']);
s/_updateIsolates/_removeDeadIsolates

https://codereview.chromium.org/1007863003/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/1007863003/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:1549: jsobj.AddPropertyF("number", "%" Pd "",
This is the same as "mainPort" above. Consider dropping it or if you keep it,
rename it to something more descriptive than "number", for example, "debugId".

https://codereview.chromium.org/1007863003/diff/1/runtime/vm/json_stream.cc
File runtime/vm/json_stream.cc (right):

https://codereview.chromium.org/1007863003/diff/1/runtime/vm/json_stream.cc#n...
runtime/vm/json_stream.cc:278: PrintValue(i);
Need JavaScript range ASSERT here too (for 64-bit architectures).

https://codereview.chromium.org/1007863003/diff/1/runtime/vm/json_stream.cc#n...
runtime/vm/json_stream.cc:285: ASSERT((-0x20000000000000LL <= i) && (i <=
0x20000000000000LL));
How about:
#define MAX_JAVASCRIPT_INT 0x20000000000000LL
#define MIN_JAVASCRIPT_INT -MAX_JAVASCRIPT_INT

https://codereview.chromium.org/1007863003/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1007863003/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:2537: // TODO(turnidge): Do we want to send some sort of
isolate update event?
dead TODO.

[turnidge, 2015-03-26 17:46:58]

https://codereview.chromium.org/1007863003/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/1007863003/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/service/object.dart:577:
_updateIsolates(map['isolates']);
On 2015/03/18 20:05:48, Cutch wrote:
> s/_updateIsolates/_removeDeadIsolates

Done.

https://codereview.chromium.org/1007863003/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/1007863003/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:1549: jsobj.AddPropertyF("number", "%" Pd "",
On 2015/03/18 20:05:48, Cutch wrote:
> This is the same as "mainPort" above. Consider dropping it or if you keep it,
> rename it to something more descriptive than "number", for example, "debugId".

Dropped mainPort.  Leaving number as-is for now after offline discussion.

https://codereview.chromium.org/1007863003/diff/1/runtime/vm/json_stream.cc
File runtime/vm/json_stream.cc (right):

https://codereview.chromium.org/1007863003/diff/1/runtime/vm/json_stream.cc#n...
runtime/vm/json_stream.cc:278: PrintValue(i);
On 2015/03/18 20:05:48, Cutch wrote:
> Need JavaScript range ASSERT here too (for 64-bit architectures).

Done.

https://codereview.chromium.org/1007863003/diff/1/runtime/vm/json_stream.cc#n...
runtime/vm/json_stream.cc:285: ASSERT((-0x20000000000000LL <= i) && (i <=
0x20000000000000LL));
On 2015/03/18 20:05:48, Cutch wrote:
> How about:
> #define MAX_JAVASCRIPT_INT 0x20000000000000LL
> #define MIN_JAVASCRIPT_INT -MAX_JAVASCRIPT_INT

Added IsJavascriptInt to utils.h.

https://codereview.chromium.org/1007863003/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1007863003/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:2537: // TODO(turnidge): Do we want to send some sort of
isolate update event?
On 2015/03/18 20:05:48, Cutch wrote:
> dead TODO.

Done.

[turnidge, 2015-03-26 19:06:38]

Committed patchset #4 (id:60001) manually as 44718 (presubmit successful).