Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 1007863003: Allow Observatory debugger to switch isolates. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/app/application.dart ('k') | runtime/observatory/lib/src/cli/command.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index c77757950197eee564a47bbcf9d680a987ec71e9..e79f3dc40ac6dd97c3b4d34dbc60446f5aa105e7 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -58,10 +58,11 @@ class SimplePage extends Page {
}
Future<Isolate> getIsolate(Uri uri) {
- return app.vm.getIsolate(uri.queryParameters['isolateId']).catchError((e) {
- Logger.root.severe('$path visit error: $e');
- return e;
- });
+ return app.vm.getIsolate(uri.queryParameters['isolateId'])
+ .catchError((e, stack) {
+ Logger.root.severe('$path visit error: $e\n$stack');
+ return e;
+ });
}
bool canVisit(Uri uri) => uri.path == path;
@@ -110,8 +111,8 @@ class VMPage extends SimplePage {
ServiceObjectViewElement serviceElement = element;
serviceElement.object = vm;
}
- }).catchError((e) {
- Logger.root.severe('VMPage visit error: $e');
+ }).catchError((e, stack) {
+ Logger.root.severe('VMPage visit error: $e\n$stack');
});
}
}
@@ -126,8 +127,8 @@ class FlagsPage extends SimplePage {
FlagListElement serviceElement = element;
serviceElement.flagList = flags;
}
- }).catchError((e) {
- Logger.root.severe('FlagsPage visit error: $e');
+ }).catchError((e, stack) {
+ Logger.root.severe('FlagsPage visit error: $e\n$stack');
});
}
}
@@ -181,6 +182,7 @@ class DebuggerPage extends SimplePage {
if (element != null) {
/// Update the page.
DebuggerPageElement page = element;
+ page.app = app;
page.isolate = isolate;
}
});
« no previous file with comments | « runtime/observatory/lib/src/app/application.dart ('k') | runtime/observatory/lib/src/cli/command.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698