Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1007513003: Fix crash in x64: handler's pc-offset must be in 32-bit uword range (Closed)

Created:
5 years, 9 months ago by srdjan
Modified:
5 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix crash in x64: handler's pc-offset must be in 32-bit uword range ( x64 -1 is out of range). Use kInvalidPcOffset = 0. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44443

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M runtime/vm/code_descriptors.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_descriptors.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/object.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
5 years, 9 months ago (2015-03-12 20:49:20 UTC) #2
Ivan Posva
LGTM -ip https://codereview.chromium.org/1007513003/diff/20001/runtime/vm/code_descriptors.h File runtime/vm/code_descriptors.h (right): https://codereview.chromium.org/1007513003/diff/20001/runtime/vm/code_descriptors.h#newcode118 runtime/vm/code_descriptors.h:118: data.outer_try_index = -1; kInvalidTryIndex This or next ...
5 years, 9 months ago (2015-03-12 20:53:35 UTC) #3
srdjan
https://codereview.chromium.org/1007513003/diff/20001/runtime/vm/code_descriptors.h File runtime/vm/code_descriptors.h (right): https://codereview.chromium.org/1007513003/diff/20001/runtime/vm/code_descriptors.h#newcode118 runtime/vm/code_descriptors.h:118: data.outer_try_index = -1; On 2015/03/12 20:53:35, Ivan Posva wrote: ...
5 years, 9 months ago (2015-03-12 21:40:00 UTC) #4
srdjan
5 years, 9 months ago (2015-03-12 21:40:11 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as r44443 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698