Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1563)

Unified Diff: runtime/vm/code_descriptors.cc

Issue 1007513003: Fix crash in x64: handler's pc-offset must be in 32-bit uword range (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_descriptors.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_descriptors.cc
===================================================================
--- runtime/vm/code_descriptors.cc (revision 44441)
+++ runtime/vm/code_descriptors.cc (working copy)
@@ -99,8 +99,9 @@
// Unreachable handler, entry not computed.
// Initialize it to some meaningful value.
const bool has_catch_all = false;
+ // Check it is uninitialized.
ASSERT((list_[i].outer_try_index == -1) &&
- (list_[i].pc_offset == -1)); // It is uninitialized.
+ (list_[i].pc_offset == ExceptionHandlers::kInvalidPcOffset));
handlers.SetHandlerInfo(i,
list_[i].outer_try_index,
list_[i].pc_offset,
« no previous file with comments | « runtime/vm/code_descriptors.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698