Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1002953005: Fix Notification (Closed)

Created:
5 years, 9 months ago by Alan Knight
Modified:
5 years, 9 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fixed formatting of the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -41 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +11 lines, -7 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +11 lines, -7 lines 0 comments Download
M tests/html/html.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/html/notification_test.dart View 1 1 chunk +49 lines, -0 lines 0 comments Download
M tools/dom/dom.json View 1 chunk +0 lines, -11 lines 0 comments Download
M tools/dom/idl/dart/dart.idl View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/dom/scripts/dartmetadata.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Notification.darttemplate View 1 chunk +12 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Alan Knight
This fixes Notification. It was converting the named arguments into a map, but not changing ...
5 years, 9 months ago (2015-03-12 20:41:32 UTC) #2
Alan Knight
dartbug.com/20513
5 years, 9 months ago (2015-03-12 20:43:35 UTC) #3
terry
lgtm
5 years, 9 months ago (2015-03-13 13:24:09 UTC) #4
Alan Knight
5 years, 9 months ago (2015-03-13 17:21:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44471 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698