Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 1002953005: Fix Notification (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixed formatting of the test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tests/html/html.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 2a991bd2c065d982ee62fad3d970e70237135933..0e03e3b38a2a8a7536d13985a55ce71382492c8e 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -24835,17 +24835,18 @@ class NodeList extends NativeFieldWrapperClass2 with ListMixin<Node>, ImmutableL
@Experimental() // experimental
class Notification extends EventTarget {
- factory Notification(String title, {String titleDir: null, String body: null,
- String bodyDir: null, String tag: null, String iconUrl: null}) {
+ factory Notification(String title, {String dir: null, String body: null,
+ String lang: null, String tag: null, String icon: null}) {
var parsedOptions = {};
- if (titleDir != null) parsedOptions['titleDir'] = titleDir;
+ if (dir != null) parsedOptions['dir'] = dir;
if (body != null) parsedOptions['body'] = body;
- if (bodyDir != null) parsedOptions['bodyDir'] = bodyDir;
+ if (lang != null) parsedOptions['lang'] = lang;
if (tag != null) parsedOptions['tag'] = tag;
- if (iconUrl != null) parsedOptions['iconUrl'] = iconUrl;
-
- return Notification._factoryNotification(title, parsedOptions);
+ if (icon != null) parsedOptions['icon'] = icon;
+ var nativeOptions;
+ nativeOptions = parsedOptions;
+ return Notification._factoryNotification(title, nativeOptions);
}
// To suppress missing implicit constructor warnings.
factory Notification._() { throw new UnsupportedError("Not supported"); }
@@ -24899,6 +24900,9 @@ class Notification extends EventTarget {
return _blink.BlinkNotification.instance.constructorCallback_1_(title);
}
+ /// Checks if this type is supported on the current platform.
+ static bool get supported => true;
+
@DomName('Notification.body')
@DocsEditable()
@Experimental() // untriaged
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tests/html/html.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698